Add missing subtype checks for table, memory, and global fields#194
Merged
fibonacci1729 merged 1 commit intobytecodealliance:mainfrom Feb 17, 2026
Merged
Conversation
The subtype checker was ignoring several fields when comparing core WebAssembly types: - Table: table64 and shared flags were bound but unused (prefixed with _) - Memory: page_size_log2 was bound but unused - Global: shared flag was bound but unused This meant two types differing only in these fields would incorrectly pass the subtype check. Added the missing comparisons and unit tests for each case.
fibonacci1729
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table64andsharedflags were bound but unused (prefixed with_)page_size_log2was bound but unusedsharedflag was bound but unused_prefixTest plan
checker.rs:mismatched_table64_is_rejected,mismatched_table_shared_is_rejected,mismatched_memory_page_size_log2_is_rejected,mismatched_global_shared_is_rejectedcargo test --workspace)